Skip to content

BUG: officially drop Python <3.12 #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucascolley
Copy link
Member

@lucascolley
Copy link
Member Author

could you review @crusaderky ?

@betatim
Copy link
Member

betatim commented Jul 8, 2025

LGTM

It would be good to have a short summary and such in the description of the PR. I assume people who discover that they can't use Python<3.12 anymore will find this PR and wonder "what the heck?" without one. Yes, we link to the issue where this was discussed but it is a long one, with back and forth, etc. So as a service to people from the future we should have a short summary here that explains why this change was made (not why this bug fix, but why drop support for old Python versions)

@lucascolley
Copy link
Member Author

as a service to people from the future we should have a short summary here that explains why this change was made (not why this bug fix, but why drop support for old Python versions)

This may have to wait until after the meeting on Thursday, or whenever @ev-br is well and able to help. Personally I do not have good justification for dropping these versions instead of keeping __array__ around for a bit to support 3.10 and 3.11.

Of course feel free to write something yourself if you do have that justification @betatim .

Copy link
Contributor

@crusaderky crusaderky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait until the meeting this Thursday to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants